Skip to content

fix wrong url test in climada.util.test.test_files#1006

Closed
emanuel-schmid wants to merge 1 commit into
developfrom
feature/fix_wrong_url_test
Closed

fix wrong url test in climada.util.test.test_files#1006
emanuel-schmid wants to merge 1 commit into
developfrom
feature/fix_wrong_url_test

Conversation

@emanuel-schmid
Copy link
Copy Markdown
Collaborator

Changes proposed in this PR:

  • the TestDownloadUrl.test_wrong_url_fail fails because nooa doesn't read the url when in maintenance mode
    So we just replace one non-valid url by another one.

This PR fixes #1004

PR Author Checklist

PR Reviewer Checklist

Copy link
Copy Markdown
Collaborator

@spjuhel spjuhel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straightforward and ok :)

@emanuel-schmid
Copy link
Copy Markdown
Collaborator Author

I leave it as it is, because failing a test while that server is on maintenance may actually be not such a bad thing.

@emanuel-schmid emanuel-schmid deleted the feature/fix_wrong_url_test branch April 7, 2025 07:27
@emanuel-schmid emanuel-schmid restored the feature/fix_wrong_url_test branch April 24, 2025 10:51
@emanuel-schmid emanuel-schmid deleted the feature/fix_wrong_url_test branch February 25, 2026 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants